[Webkit-unassigned] [Bug 192314] [WinCairo] Enable WebGL 2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192314

--- Comment #8 from Kenneth Russell <kbr at google.com> ---
(In reply to Fujii Hironori from comment #7)
> (In reply to Fujii Hironori from comment #4)
> > A lot of tests are failing under webgl/2.0.0/conformance2/textures, for
> > example,
> 
> Only texSubImage2D[SubSource] tests are failing.
> There are suspicious FIXME comments in
> WebGLRenderingContextBase::texImageSourceHelper for Cairo ports.
> 
> > // FIXME: Enable this path with ANGLE. Only used with Cairo, not on macOS or iOS.
> > // If possible, copy from the bitmap directly to the texture
> > // via the GPU, without a read-back to system memory.
> > //
> > // FIXME: restriction of (RGB || RGBA)/UNSIGNED_BYTE should be lifted when
> > // ImageBuffer::copyToPlatformTexture implementations are fully functional.

Ah, yes. That code path tries to handle the case where the ImageBitmap is backed by a GPU texture, and tries to copy it directly to the destination WebGL texture.

Could you see whether the extension in Source/ThirdParty/ANGLE/extensions/CHROMIUM_copy_texture.txt provides the needed functionality, and lets you skip the query of the texture's internal format? With the ANGLE backend, WebGLTextures don't track their internal format any more.

Note, I would have thought that the fall-through case (which uses CPU readbacks) would have at least made the tests pass, even if they're slower than desired. Could you investigate exactly what's going wrong with the texSubImage2D[SubSource] tests?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201221/77c3126c/attachment.htm>