[Webkit-unassigned] [Bug 220062] New: warning: enumerated and non-enumerated type in conditional expression in Compiler.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220062

            Bug ID: 220062
           Summary: warning: enumerated and non-enumerated type in
                    conditional expression in Compiler.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: ANGLE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: dino at apple.com

[740/5326] Building CXX object Source/...src/compiler/translator/Compiler.cpp.o
../../Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp: In member function ‘bool sh::TCompiler::checkAndSimplifyAST(sh::TIntermBlock*, const sh::TParseContext&, ShCompileOptions)’:
../../Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:726:43: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
  725 |     unsigned int simplifyScalarized = (compileOptions & SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS)
      |                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  726 |                                           ? IntermNodePatternMatcher::kScalarizedVecOrMatConstructor
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  727 |                                           : 0;
      |                                           ~~~

So we could fight warnings like this as they appear... but honestly, building ANGLE with -Wextra is too aggressive IMO. -Wextra is great for code that we control, where the burden of squashing warnings is relatively low. But with ANGLE, we have to either land fixes upstream, or carry them downstream forever. It doesn't make sense to bother with this for minor build warning fixes when upstream is clearly not using the same warning flags and/or same compiler that we do. So I suggest we simply disable -Wextra for all of ANGLE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201221/b00ca519/attachment.htm>