[Webkit-unassigned] [Bug 219995] [GTK][WPE] Expose setCORSDisablingPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219995

--- Comment #11 from Adrian Perez <aperez at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #7)
> Comment on attachment 416474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416474&action=review
>
> [...]
> 
> > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4717
> > + * webkit_web_view_set_cors_disabling_patterns:
> 
> what about webkit_web_view_set_cors_allow_list()?

I also like _set_cors_allow_list() better, as it is more consistent having
a name used elsewhere in the public API =) 

> > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4729
> > +    if (!patterns || !g_strv_length(const_cast<char**>(patterns)))
> 
> I don't think we should return early in this case. Setting an empty list is
> the only way to reset the patterns. That's what
> updateCORSDisablingPatterns() does. I think we should mark patterns as
> nullable and document that if it's NULL or empty the patterns will be reset.
> I think this is consistent with webkit_user_script_new().

Agreed as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201218/a78c49cd/attachment.htm>