[Webkit-unassigned] [Bug 219993] $(findstring iphone, $(SDKROOT)) fails when SDKROOT is not lowercase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219993

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #416470|review?                     |review+
              Flags|                            |

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 416470
  --> https://bugs.webkit.org/attachment.cgi?id=416470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416470&action=review

> Source/Makefile:6
> +	ifneq (,$(findstring macosx,$(notdir $(call to_lower,$(SDKROOT)))))

I think it would be better to call notdir first before calling shell, so we pass a shorter string. Not sure why we used all lowercase for "to_lower" when we use all uppercase for other make variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201217/f2148fb0/attachment.htm>