[Webkit-unassigned] [Bug 218093] [css-logical] Implement logical border-radius

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218093

--- Comment #22 from zsun at igalia.com ---
(In reply to zsun from comment #8)
> (In reply to Javier Fernandez from comment #3)
> > Comment on attachment 416234 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=416234&action=review
> > 
> > > Source/WebCore/platform/text/WritingMode.h:193
> > > +            if (isHorizontalWritingMode(writingMode) || isFlippedLinesWritingMode(writingMode))
> > 
> > Isn't this equivalent to !isFlippedBlockWritingMode() (aka: vertical-rl) ?
> > 
> > > Source/WebCore/platform/text/WritingMode.h:210
> > > +        if (isHorizontalWritingMode(writingMode) || isFlippedLinesWritingMode(writingMode))
> > 
> > Ditto
> > 
> > > Source/WebCore/platform/text/WritingMode.h:221
> > > +        if (isHorizontalWritingMode(writingMode) || isFlippedLinesWritingMode(writingMode))
> > 
> > Ditto
> > 
> > > Source/WebCore/platform/text/WritingMode.h:226
> > > +            if (isHorizontalWritingMode(writingMode) || isFlippedLinesWritingMode(writingMode))
> > 
> > Ditto
> 
> Yes, it might be worthy introducing isFlippedBlockWritingMode() in
> WritingMode.h. As we discussed, I probably will leave this to a separate
> patch.

isFlippedWritingMode(WritingMode writingMode) has been define 
in WritingMode.h. I guess probably it's enough without introducing isFlippedBlockWritingMode(). 

Patch has been updated. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201217/3f2a95df/attachment-0001.htm>