[Webkit-unassigned] [Bug 219943] [WASM-References] Add support for memory.copy, memory.init and data.drop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219943

--- Comment #9 from Dmitry <dbezhetskov at igalia.com> ---
Comment on attachment 416402
  --> https://bugs.webkit.org/attachment.cgi?id=416402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416402&action=review

>> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:759
>> +            Segment* segment = Segment::create(*initExpr, dataByteLength, Segment::Kind::Active);
> 
> Let's receive this as `auto segment = Segment::create(*initExpr, dataByteLength, Segment::Kind::Active);`.
> And let's keep Segment* pointer by doing like, `Segment* segmentPtr = segment.get();`.

Actually we can just move m_info->data.uncheckedAppend(Segment::adoptPtr(segment)); after the loop

>> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:761
>> +            m_info->data.uncheckedAppend(Segment::adoptPtr(segment));
> 
> Let's pass it with `WTFMove(segment)`.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201217/a3d39382/attachment.htm>