[Webkit-unassigned] [Bug 219930] GamepadButton.prototype is missing 'touched' attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 10:03:01 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=219930

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dino at apple.com
 Attachment #416344|review?                     |review+
              Flags|                            |

--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 416344
  --> https://bugs.webkit.org/attachment.cgi?id=416344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416344&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please remove this line. You don't need to list a new test since you've modified an existing one.

> Source/WebCore/Modules/gamepad/GamepadButton.cpp:50
> +    If the button is capable of detecting touch, this property MUST be true if the button is currently being touched, and false otherwise. If the button is not capable of detecting touch and is capable of reporting an analog value, this property MUST be true if the value property is greater than 0, and false if the value is 0. If the button is not capable of detecting touch and can only report a digital value, this property MUST mirror the pressed attribute.

Please wrap this line.

Also, I think we need to add a comment on the implementation  e.g.

FIXME: Update if/when we can support touches on a controller.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201216/0419bef1/attachment-0001.htm>


More information about the webkit-unassigned mailing list