[Webkit-unassigned] [Bug 218093] [css-logical] Implement logical border-radius

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218093

--- Comment #13 from zsun at igalia.com ---
(In reply to zsun from comment #10)
> (In reply to Simon Fraser (smfr) from comment #6)
> > Comment on attachment 416234 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=416234&action=review
> > 
> > > Source/WebCore/css/CSSProperty.cpp:175
> > > +    case CSSPropertyBorderStartStartRadius: {
> > > +        return resolveToPhysicalProperty(direction, writingMode, LogicalRadiusCorner::StartStart, borderRadiusShorthand());
> > > +    }
> > > +    case CSSPropertyBorderStartEndRadius: {
> > > +        return resolveToPhysicalProperty(direction, writingMode, LogicalRadiusCorner::StartEnd, borderRadiusShorthand());
> > > +    }
> > > +    case CSSPropertyBorderEndStartRadius: {
> > > +        return resolveToPhysicalProperty(direction, writingMode, LogicalRadiusCorner::EndStart, borderRadiusShorthand());
> > > +    }
> > > +    case CSSPropertyBorderEndEndRadius: {
> > > +        return resolveToPhysicalProperty(direction, writingMode, LogicalRadiusCorner::EndEnd, borderRadiusShorthand());
> > > +    }
> > 
> > No need for braces on these.
> > 
> > >> Source/WebCore/platform/text/WritingMode.h:132
> > >> +enum class LogicalRadiusCorner : uint8_t {
> > > 
> > > In the future there might be more properties referencing corners, other than border radius.
> > > So it may be better to name the enums like LogicalBoxCorner and BoxCorner.
> > > Seems I missed this in the Chromium review...
I will try to update the Chromium changes.
> > 
> > I concur. See BoxSide and LogicalBoxSide.
> > 
> > > Source/WebCore/platform/text/WritingMode.h:187
> > > +inline RadiusCorner mapLogicalRadiusCornerToPhysicalRadiusCorner(TextFlow textflow, WritingMode writingMode, LogicalRadiusCorner logicalRadiusCorner)
> > 
> > This can be called mapLogicalCornerToPhysicalCorner()
> 
> Code updated. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201216/57d5c4ec/attachment.htm>