[Webkit-unassigned] [Bug 219595] [WASM-References] Add support for type annotated select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219595

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #416143|review?                     |review-
              Flags|                            |

--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416143
  --> https://bugs.webkit.org/attachment.cgi?id=416143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416143&action=review

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:652
> +        m_expressionStack.constructAndAppend(zero.type(), result);

Using immediates.targetType is better for future extension?

> Source/JavaScriptCore/wasm/wasm.json:48
> +        "annotated_select":    { "category": "control",    "value":  28, "return": ["prev"],                         "parameter": ["any", "prev", "bool"],        "immediate": [{"name": "value_type",     "type": "value_type"}],                                            "description": "the same as just select but with a value type immediate" },

https://webassembly.github.io/reference-types/core/binary/instructions.html#parametric-instructions is showing `��������  ��∗:������(��������������)`, but it looks like this definition is not that one.
Can you fix it? br_table's definition would be useful to fix it.

> JSTests/wasm/wasm.json:48
> +        "annotated_select":    { "category": "control",    "value":  28, "return": ["prev"],                         "parameter": ["any", "prev", "bool"],        "immediate": [{"name": "value_type",     "type": "value_type"}],                                            "description": "the same as just select but with a value type immediate" },

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201215/bd68338d/attachment-0001.htm>