[Webkit-unassigned] [Bug 219870] "make clean" fails on EmptyDSTROOT target

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219870

--- Comment #3 from Ryan Hostetler <rhost at apple.com> ---
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 416188 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416188&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:14427
> > +				PRODUCT_NAME = "$(TARGET_NAME)";
> 
> How do we decide when to put PRODUCT_NAME in xcconfig, and when do we put it
> in pbxproj? I see precedent for both.

There are a few similar script-only aggregate targets in bmalloc, JavaScriptCore, libwebrtc, WTF that keep this setting in pbxproj.
I opted for the pbxproj approach as to not introduce a new file for a target that is designed to work around a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201215/64e3b3e5/attachment.htm>