[Webkit-unassigned] [Bug 219848] [WASM-References] Add support for memory.fill

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219848

--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416145
  --> https://bugs.webkit.org/attachment.cgi?id=416145
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416145&action=review

>> Source/JavaScriptCore/wasm/WasmMemory.cpp:624
>> +        auto locker = holdLock(m_handle->lock());
> 
> I don't think we need this locking. When size is updated, mprotect is already done (because mprotect has memory barrier).
> So, if `if (offset + count > m_handle->size())` pass, then we can just perform this without taking a lock.
> So, I think we can just remove `doMemoryFill` function, and merge it into `Memory::fill`.

Note that, if the memory mode is MemorySharingMode::Shared, underlying memory never gets replaced. mprotect will just extend it if memory grows.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201215/51274f90/attachment.htm>