[Webkit-unassigned] [Bug 219672] [GPU Process] Cache Font objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219672

--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 415728 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415728&action=review
> 
> >>> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:934
> >>> +class CacheFont {
> >> 
> >> CacheFont is an odd name. CachedFont?
> > 
> > As a display list item, CacheFont is a more reasonable name, since it describes what the item is doing.
> > 
> > But perhaps something like "RegisterCachedFont" would be more clear.
> 
> Oh I missed that this is a DL item because there's no inheritance. Maybe
> CacheFontItem?

Perhaps. But if we want to add an "Item" suffix here, I'd prefer to do that for all display list items for consistency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201209/8fb04a46/attachment.htm>