[Webkit-unassigned] [Bug 219297] [WASM-References] Add table.init

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219297

--- Comment #10 from Dmitry <dbezhetskov at igalia.com> ---
Comment on attachment 415626
  --> https://bugs.webkit.org/attachment.cgi?id=415626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415626&action=review

>> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1163
>> +    return { };
> 
> Do we need exception check here? Looks like elem_drop instruction never returns false.

Ah, thanks, fixed!

>> Source/JavaScriptCore/wasm/WasmInstance.cpp:168
>> +const Element* Instance::elem(unsigned i) const
> 
> Let's name it `elementAt`.

renamed

>> Source/JavaScriptCore/wasm/WasmOperations.cpp:724
>> +JSC_DEFINE_JIT_OPERATION(operationWasmElemDrop, bool, (Instance* instance, unsigned elementIndex))
> 
> Let's make return type "void" since it always returns "true".

Done

>> Source/JavaScriptCore/wasm/wasm.json:73
>> +        "elem.drop":           { "category": "exttable",   "value":  252, "return": ["i32"],                         "parameter": [],                             "immediate": [{"name": "element_index",  "type": "varuint32"}],                                             "description": "prevents further use of a passive element segment", "extendedOp": 13 },
> 
> Ditto for elem.drop. And can you check the other table instructions too?

Yeah, I noticed that too when I looked at table.fill, copied code and forgot about it :)
Fixed table.copy, elem.drop and table.fill.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201209/34a1740d/attachment.htm>