[Webkit-unassigned] [Bug 219457] [WPE][JSC] Some JSC GLib API symbols are not being exported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219457

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
(In reply to Adrian Perez from comment #1)
> Okay, I think that the most proper solution for this issue will
> be what Don is hacking for bug #210366 but I have a WIP patch which
> only does the minimal set up to arrange linker flags to pass the
> following when linking the main library when the JavaScriptCore
> target is a static library:
> 
>   -Wl,--whole-archive path/to/libJavaScriptCore.a -Wl,--no-whole-archive

For reference this is the hack that I have applied locally to achieve
this and get the symbols to be in the shared library object:

diff --git a/Source/WebKit/CMakeLists.txt b/Source/WebKit/CMakeLists.txt
index be0865132bf..7f8bc738499 100644
--- a/Source/WebKit/CMakeLists.txt
+++ b/Source/WebKit/CMakeLists.txt
@@ -598,3 +598,9 @@ else ()
         RUNTIME DESTINATION "${LIBEXEC_INSTALL_DIR}"
     )
 endif ()
+
+target_link_libraries(WebKit PUBLIC
+    -Wl,--whole-archive
+    $<TARGET_PROPERTY:WebKit::JavaScriptCore,INTERFACE_LINK_LIBRARIES>
+    -Wl,--no-whole-archive
+)

…which is an ugly hack, so I am going to close this in favor of
tackling bug #210366 — I'll try and help out Don with that one.

*** This bug has been marked as a duplicate of bug 210366 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201208/1bad119a/attachment-0001.htm>