[Webkit-unassigned] [Bug 219600] Support JS type reflections in WebAssembly JS-API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219600

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #415554|review?                     |review-
              Flags|                            |

--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 415554
  --> https://bugs.webkit.org/attachment.cgi?id=415554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415554&action=review

Looks good, but put r- since I found bugs, And, can you update the LayoutTests results to make EWS green?

> Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp:74
> +        JSValue minSizeValue = memoryDescriptor->get(globalObject, minimum);

We need

RETURN_IF_EXCEPTION(throwScope, encodedJSValue());

here since `->get(...)` can throw an error.

> Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:85
> +    JSValue minSizeValue = memoryDescriptor->get(globalObject, minimumIdent);

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201208/db098ea0/attachment-0001.htm>