[Webkit-unassigned] [Bug 219421] [WinCairo] Enable USE_ANGLE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219421

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 415192
  --> https://bugs.webkit.org/attachment.cgi?id=415192
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415192&action=review

Thank you very much for the review. I will check and add my comments later.

>> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:250
>> +#elif PLATFORM(WIN)
> 
> To clarify the code, you could consider to do following:
> - make the above elif an #else
> - change IOSurfaceTextureTarget to "drawingBufferTextureTarget()"
> 
> so your code would be 
> 
> #else 
>  GLenum textureTarget = drawingBufferTexture();
>  gl::BindTexture(textureTarget, m_texture);   
>  gl::TexImage2D(textureTarget, 0, m_internalColorFormat, width, height, 0, colorFormat, GL_UNSIGNED_BYTE, 0);
>  #If USE(COORDINATED_GRAPHICS)
>  if (m_compositorTexture) {
>     ...
>  }
>  #endif
> #endif

Sounds nice. 
Filed: Bug 219475 – GraphicsContextGLOpenGL: Rename IOSurfaceTextureTarget to drawingBufferTextureTarget

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201203/9c541900/attachment-0001.htm>