[Webkit-unassigned] [Bug 219427] [WASM-References] Add support for table.copy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219427

--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 415201
  --> https://bugs.webkit.org/attachment.cgi?id=415201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415201&action=review

Looks good. Can you change the operation to use Checked<> though?

> Source/JavaScriptCore/wasm/WasmOperations.cpp:729
> +static bool isSumOverflow(uint32_t lhs, uint32_t rhs)
> +{
> +    const uint64_t sum = static_cast<uint64_t>(lhs) + static_cast<uint64_t>(rhs);
> +    return sum > static_cast<uint64_t>(std::numeric_limits<int32_t>::max());
> +}

I think you can use Checked<uint32_t> for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201202/d82e32a9/attachment.htm>