[Webkit-unassigned] [Bug 215992] New: EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215992

            Bug ID: 215992
           Summary: EnabledBySetting extended attributes on a partial
                    interface do not get merged with EnabledBySetting
                    extended attributes on properties of that partial
                    interface
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Bindings
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sam at webkit.org
                CC: cdumez at apple.com

While investigating https://bugs.webkit.org/show_bug.cgi?id=215981, one failure was in the generation of NavigatorMediaDevices.idl which currently looks like:

[
    Conditional=MEDIA_STREAM,
    EnabledAtRuntime=MediaDevices,
] partial interface Navigator {
    [SameObject, SecureContext, ContextAllowsMediaDevices] readonly attribute MediaDevices mediaDevices;
    [Custom, EnabledBySetting=LegacyGetUserMedia] undefined getUserMedia(object constraints, object? successCallback, object? errorCallback);
};

One thing to note here is that the extended attributes on the partial interface declaration itself (Conditional=MEDIA_STREAM and EnabledAtRuntime=MediaDevices) are really shorthand for mapping those extended attributes to all the member properties.

In the mentioned bug, I want to change the partial interface wide "EnabledAtRuntime=MediaDevices" to "EnabledBySetting=MediaDevices", which maps the EnabledBySetting to each member of the partial interface. The issue is that the code generator currently overwrites "EnabledBySetting=LegacyGetUserMedia" on the getUserMedia operation, but really it would make more sense to merge them.

This seems to be a general problem for many potentially mergeable extended attributes, we already kind of merge "Conditional" extended attributes, but only for operations for some reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200830/03db3d00/attachment.htm>