[Webkit-unassigned] [Bug 215886] REGRESSION(r266221) Layout tests step hanging due to slow WaveDiff comparison

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215886

Lauro Moura <lmoura at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION(r266221) Layout  |REGRESSION(r266221) Layout
                   |tests step hanging          |tests step hanging due to
                   |                            |slow WaveDiff comparison

--- Comment #4 from Lauro Moura <lmoura at igalia.com> ---
(In reply to Chris Dumez from comment #3)
> 
> I was just trying to help you get back in a good state.

Sure, sure. Thanks.

In the loop-points test, the new test results had small deviations that increased as the frequency increased (looping was right, though).

This caused the WaveDiff class to generate a sample diff for 340k of the 666k samples.

And as the current WaveDiff uses string concat for each sample diff, it ended up being too slow, likely leading the timeout to be triggered on the test controller and it somehow losing track of the runner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200827/1763f278/attachment-0001.htm>