[Webkit-unassigned] [Bug 215229] Step animations invalidate style on every rendering update whether or not they need to

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 27 09:46:52 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=215229

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 407397
  --> https://bugs.webkit.org/attachment.cgi?id=407397
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407397&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1498
> +    if (m_acceleratedPropertiesState == AcceleratedProperties::None || m_someKeyframesUseStepsTimingFunction || is<StepsTimingFunction>(timingFunction()))

It's GraphicsLayerCA that decides that it can't accelerate animations with steps() timing functions, so adding this code here is spreading that logic around into two places. Not great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200827/5939f3a1/attachment.htm>


More information about the webkit-unassigned mailing list