[Webkit-unassigned] [Bug 215863] New: [webkitpy] repository svn version is incorrect when working on a branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215863

            Bug ID: 215863
           Summary: [webkitpy] repository svn version is incorrect when
                    working on a branch
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, cgarcia at igalia.com

It seems than when you are working on a SVN branch, the SVN revision pointed by HEAD will *not* be the last change done on your branch, but the last change done on trunk (which is irrelevant for your checkout)

See this example:

1. Check out webkitgtk-2.28.0 svn branch
$ svn co http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.28.0 build
# .... lot of files
Checked out revision 266187.

2. Check what svn info says:
$ cd build
$ svn info
Path: .
Working Copy Root Path: /tmp/build
URL: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.28.0
Relative URL: ^/releases/WebKitGTK/webkit-2.28.0
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 266187
Node Kind: directory
Schedule: normal
Last Changed Author: carlosgc at webkit.org
Last Changed Rev: 258193
Last Changed Date: 2020-03-10 12:10:24 +0100 (Tue, 10 Mar 2020)



So, the last change done on that branch was in reality r258193 (2020-03-10), but svn is saying that my working copy is r266187 (basically trunk of today)


This causes the tool glib-revision to print the wrong revision, which then is passed to the build and the version stamped for the build is incorrect.

$ Tools/glib/svn-revision 
r266187


I think we should pick the "Last Changed Rev" changeset instead of the "Revision" changeset from svn info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200826/18700ead/attachment-0001.htm>