[Webkit-unassigned] [Bug 215519] Use closeReason provided in didCloseWithCode delegate for the NSURLSessionWebSocket code path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 12:38:20 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=215519

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 406612
  --> https://bugs.webkit.org/attachment.cgi?id=406612
Using the closeReason in the delegate

View in context: https://bugs.webkit.org/attachment.cgi?id=406612&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1021
> +        auto closeReason = adoptNS([[NSString alloc] initWithData:reason encoding:NSUTF8StringEncoding]);

ASSERT([reason isEqualToData:task.closeReason]);
That'll catch these future bugs you mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200814/2d8dbfb3/attachment.htm>


More information about the webkit-unassigned mailing list