[Webkit-unassigned] [Bug 215353] [ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215353

--- Comment #4 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
>From the history of this test and from other tests, I think the flakiness is in GCController.collect(). Calling this function from JS does not guarantee the memory of all the deallocated objects is garbage-collected. Multiple calls to GCController.collect() may be invoked to overcome this problem. Putting idle time before requesting the numberOfLiveNodes() might be need as well.

This is a stress test. It adds 100 <use> elements. In each one of them an <animate> element is added. So these objects are allocated then deallocated:

1. <use> elements, each with animated properties.
2. Shadow trees in which there is a <rect> element is created with its animated properties 
3. <animate> elements
4. SVGAnimators for the <animate> elements
5. Renderers for all the <use> and the <rect> elements in the shadow trees.

Since the GCController.collect() is flaky, I think we have to make the number of elements small such that there is kind of guarantee all the deallocated memory will be garbage collected during the test trials. I think adding three <use> elements should be enough to test the SVG animated properties do not leak. And allocating and freeing this number of objects should not exercise the flakiness of GCController.collect().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200813/b4a2a31f/attachment.htm>