[Webkit-unassigned] [Bug 215032] REGRESSION(r261570): [GTK] Fails to send drop event to JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=215032

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #406378|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 406378
  --> https://bugs.webkit.org/attachment.cgi?id=406378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406378&action=review

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:337
> +                for (auto& type : customData.orderedTypes())
> +                    types.add(type);

Are these guaranteed to be ASCII lowercase?

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:348
> +        return copyToVector(types);

This will yield the types in a random order, based on hashing. I think we probably want this sorted.

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:462
> +            const auto& customData = data[0];

Why is it correct to look only at the first item?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200811/76cf3635/attachment.htm>