[Webkit-unassigned] [Bug 215349] New: Clean up DragApplicationFlags after switch to OptionSet<>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 16:54:17 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=215349

            Bug ID: 215349
           Summary: Clean up DragApplicationFlags after switch to
                    OptionSet<>
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: cdumez at apple.com, darin at apple.com
        Depends on: 215341

Bug 215341 fixed a WebContent crash, but there are a couple things to clean up:

1. DragApplicationFlags::DragApplicationNone can be removed.
2. DragApplicationFlags should be an enum class so DragApplicationFlags::DragApplicationIsModal becomes DragApplicationFlags::IsModal.
3. -[WebView applicationFlags:] should return an OptionSet<WebCore::DragApplicationFlags>.  (Fix call sites that use it.)
4. Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp should use OptionSet<WebCore::DragApplicationFlags> within the function.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=215341
[Bug 215341] AuxiliaryProcess::didReceiveInvalidMessage() for WebPage::PerformDragControllerAction IPC
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200810/6d49096a/attachment-0001.htm>


More information about the webkit-unassigned mailing list