[Webkit-unassigned] [Bug 211189] [GTK4][X11] Add support for rendering web view contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211189

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #2)
> Comment on attachment 397970 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397970&action=review
> 
> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> > +#define WK_XVISUAL(platformDisplay) (static_cast<Visual*>(platformDisplay.visual()))
> 
> /me sighs at X11 (╥_╥)
> 
> > Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> > +    auto* visual = WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));
> 
> Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
> I doubt that GTK would choose one different from what
> PlatformDisplayX11::visual()
> finds.

I prefer not to change the GTK3 behavior, even less in X11 related code that I don't test myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200430/5422bc45/attachment.htm>