[Webkit-unassigned] [Bug 211207] New: REGRESSION(r260791) Network process fails to suspend promptly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211207

            Bug ID: 211207
           Summary: REGRESSION(r260791) Network process fails to suspend
                    promptly
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cdumez at apple.com
                CC: achristensen at apple.com, darin at apple.com,
                    ggaren at apple.com
            Blocks: 211080

Network process fails to suspend promptly because NetworkProcess::prepareToSuspend() does not call its completion handler.

This issue is with this code and was caused by using the same WorkQueue for all ITP stores:
"""
    forEachNetworkSession([&callbackAggregator](auto& networkSession) {
        if (auto* resourceLoadStatistics = networkSession.resourceLoadStatistics()) {
            if (!resourceLoadStatistics->isEphemeral()) {
                WTFLogAlways("CHRIS: resourceLoadStatistics::BEGIN");
                resourceLoadStatistics->suspend([callbackAggregator] { WTFLogAlways("CHRIS: resourceLoadStatistics::END"); });
            }
        }
    });
"""

On first loop iteration, resourceLoadStatistics->suspend() hangs/suspends the WorkQueue so every follow-up iteration will hang when calling resourceLoadStatistics->suspend().


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=211080
[Bug 211080] Stop using waiting for a BinarySemaphore on the main thread in the NetworkProcess
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200429/e9a4eb91/attachment.htm>