[Webkit-unassigned] [Bug 211073] [GTK4] Add support for motion events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211073

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 397675
  --> https://bugs.webkit.org/attachment.cgi?id=397675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397675&action=review

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1136
>> +    // FIXME: Forward event to dialog.
> 
> Wouldn't this be “if (priv->dialog) return GDK_EVENT_PROPAGATE;” like
> in the function right above? If so, I think we should do it already for
> this patch and remove this FIXME.

No, in the case of motion events we are not just returning propagate but chaining up. I don't remember why, so I prefer to wait until we implement the dialogs to see what we need to do here.

>> Tools/MiniBrowser/gtk/BrowserTab.c:410
>> +#if !GTK_CHECK_VERSION(3, 98, 0)
> 
> How about removing the margin also for GTK3 so we don't need the #if here?

Or adding it in the case of GTK4, but I don't know how or whether it's possible. This bug is not about this, that's why I didn't change any behavior here, I added back the overlay just to avoid runtime criticals and check that items are properly hovered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200428/a06808a0/attachment.htm>