[Webkit-unassigned] [Bug 211021] [GTK4][Wayland] Add support for rendering web view contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211021

Claudio Saavedra <csaavedra at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |csaavedra at igalia.com

--- Comment #4 from Claudio Saavedra <csaavedra at igalia.com> ---
(In reply to Adrian Perez from comment #3)
> Comment on attachment 397563 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397563&action=review
> 
> Looks good overall, I have left a few comments but nothing that should
> prevent landing.
> 
> > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:606
> > +    gtk_widget_set_vexpand(viewWidget, TRUE);
> 
> Wouldn't we also want a call to gtk_widget_set_hexpand(viewWidget, TRUE)
> here?
> In general we want the web view to take as much space as possible inside its
> continer, in both directions, unless I am missing something.

It's been a long time since I wrote any GTK+ widget, so take this with a grain of salt. But the idea is that for widgets there's a natural direction of expansion. In the case of the webview, that would be vertical (as that's how usually the content flow for webpages goes). Horizontal expansion is not necessarily wanted, that depends on what horizontal siblings the widget has and how the application wants to distribute the space between them.

This can be of course overriden by the application developers, just like with any widget.

> 
> > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:754
> > +    *minimumSize = 0;
> 
> Is it really useful to have zero as the minimum size? I know that using zero
> as
> minimum is the current behaviour for GTK3 as well, but it strikes me as odd
> because
> that can lead to situations like having a simple window without window
> controls
> and only a web view inside having a 0×0 size if
> gtk_window_set_default_size() was
> not called on the window—and that seems… bad?

Minimum size is the hard minimum. If you have anything other than 0x0 then apps that need a smaller size will not be able to do that. If an app is not setting a reasonable size for its windows, that's their bug.


Also with a grain of salt, as I said it's been a while since I wrote GTK+ widget layout code of any kind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200428/17ca1f39/attachment.htm>