[Webkit-unassigned] [Bug 211089] New: [JSC] Add $vm.assertEnabled() to suppress Debug crash expected tests in release+assert build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211089

            Bug ID: 211089
           Summary: [JSC] Add $vm.assertEnabled() to suppress Debug crash
                    expected tests in release+assert build
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ysuzuki at apple.com

We have ASSERT which only fires when DOM object is wrongly implemented to catch wrong ones.
We are using ASSERT in JSC side since we don't know all the DOM objects are correctly implemented. If it is not correctly implemented, in Release build, JSC is returning sub-optimal results. But in Debug build, we can catch the wrong ones, which allows us to fix the wrong thing while avoiding catastrophic crashes in release build.

However, the test is assuming that ASSERT is not enabled if it is not Debug build. Release & Debug builds work, but Release+Assert does not meet this assumption.

So, skip this based on `$vm.assertEnabled()`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200427/547062aa/attachment.htm>