[Webkit-unassigned] [Bug 210911] Nullptr crash in objc_msgSend under WebCore::genericFamily

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 10:02:02 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=210911

--- Comment #13 from Darin Adler <darin at apple.com> ---
(In reply to Antti Koivisto from comment #9)
>  dynamic_cf_cast does have debug assert so it seems equivalent to my
> original patch:
> 
>     ASSERT_WITH_SECURITY_IMPLICATION(CFGetTypeID(object) ==
> CFTypeTrait<T>::typeID());
>     if (CFGetTypeID(object) != CFTypeTrait<T>::typeID())
>         return nullptr;

Don’t get me started, though. dynamic_cf_cast is the wrong name for a function if it asserts, because dynamic_cast and dyanmic_objc_cast don’t!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200424/9322c21f/attachment.htm>


More information about the webkit-unassigned mailing list