[Webkit-unassigned] [Bug 210561] [GTK] excessive wakeups/polling due to gdk_frame_clock_begin_updating

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210561

--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Milan Crha from comment #21)
> Is it good idea to:
> 
>    ASSERT(frameClock);
> 
> on both places? The gtk_widget_get_frame_clock() can return NULL, according
> to its documentation.

Yes, but in this case we are creating a toplevel that we manually realize, so the frame clock is already created for sure.

> You can also use g_signal_handlers_disconnect_by_data(), which was added in
> glib 2.32. I do not see which version of glib WebKitGTK depends on (not from
> FindGLIB.cmake at least).

I guess it doesn't matter unless it's more efficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200424/320e74e2/attachment.htm>