[Webkit-unassigned] [Bug 168593] ASSERTION FAILED: "m_state != ParseError" when adding Unicode flag to RegExp whose pattern isn't valid under Unicode mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168593

Gary Kwong [:gkw] [:nth10sd] <nth10sd at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nth10sd at gmail.com

--- Comment #1 from Gary Kwong [:gkw] [:nth10sd] <nth10sd at gmail.com> ---
I ran robobisect against this bug, and after the following commit:

commit ea375360dc2966035e4f7b3e57749b63454e4bf9
Author: msaboff
Date:   Fri May 18 02:59:31 2018 +0000

    We don't throw SyntaxErrors for runtime generated regular expressions with errors
    https://bugs.webkit.org/show_bug.cgi?id=185755

    Reviewed by Keith Miller.

    </snip>

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231939 268f45cc-cd09-0410-ab3c-d52691b4dbfc


it no longer throws the assertion failure, instead showing:

Exception: SyntaxError: Invalid regular expression: invalid escaped character for unicode pattern

:msaboff, is this a likely fix or is this merely hiding the bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200424/fde84e2b/attachment.htm>