[Webkit-unassigned] [Bug 210916] New: Regresion after r260359 ([GTK][WPE] lowWatermarkPages() in MemoryPressureMonitor.cpp only searches the "low" value inside the first "Node" section)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210916

            Bug ID: 210916
           Summary: Regresion after r260359 ([GTK][WPE]
                    lowWatermarkPages() in MemoryPressureMonitor.cpp only
                    searches the "low" value inside the first "Node"
                    section)
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: psaavedra at igalia.com
                CC: bugs-noreply at webkitgtk.org
            Blocks: 210345

Changes in https://bugs.webkit.org/show_bug.cgi?id=210345 leaks file descriptors:


```
This change is leaking file handles. I see constant additions of the triple:

  /proc/meminfo
  /proc/zoneinfo
  /proc/18738/cgroup

in `lsof -p PID`. It lasts up to the top opened files limit is reached.

You should, in MemoryPressureMonitor::start(), fclose() those which had been opened, both in the 'continue' and in the end of the while() (not only after it, which handles the 'break' path).
```

Ref: https://bugs.webkit.org/show_bug.cgi?id=210345#c5


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=210345
[Bug 210345] [GTK][WPE] lowWatermarkPages() in MemoryPressureMonitor.cpp only searches the "low" value inside the first "Node" section
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200423/5c165a35/attachment.htm>