[Webkit-unassigned] [Bug 210814] New: Clean up QuickLookThumbnailLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210814

            Bug ID: 210814
           Summary: Clean up QuickLookThumbnailLoader
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: darin at apple.com, nmouchtaris at apple.com
        Depends on: 208891

Clean up QuickLookThumbnailLoader.

The clang static analyzer noticed two new potential leaks in r260407 for Bug 208891:

'WKQLThumbnailQueueManager' lacks a 'dealloc' instance method but must release '_qlThumbnailGenerationQueue'
'WKQLThumbnailLoadOperation' lacks a 'dealloc' instance method but must release '_contentType'

Neither leak would occur in practice because WKQLThumbnailLoadOperation._contentType was completely unused(!), and WKQLThumbnailQueueManager uses a +sharedInstance pattern that would likely never deallocate the shared object instance that is created.

However, after investigating the leaks, I found some other things that could be cleaned up.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=208891
[Bug 208891] Modern WebKit: QuickLook for attachment elements
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200421/25aab00a/attachment.htm>