[Webkit-unassigned] [Bug 209118] [GTK] UI process crash when entering compositing mode when WPE_RENDERER is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 16 13:40:35 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=209118

--- Comment #25 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 396639
  --> https://bugs.webkit.org/attachment.cgi?id=396639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396639&action=review

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:101
> +        const char* extensions = eglQueryString(eglDisplay, EGL_EXTENSIONS);
> +        if (!GLContext::isExtensionSupported(extensions, "EGL_WL_bind_wayland_display"))
>              return false;

Doesn't it make more sense to check this first, instead of initializing wpebackend-fdo and then giving up here even if initialization succeeded?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200416/016fe116/attachment-0001.htm>


More information about the webkit-unassigned mailing list