[Webkit-unassigned] [Bug 210570] New: ThreadedScrollingTree::scrollingTreeNodeDidScroll() should protect the m_scrollingCoordinator when dispatching its async operation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210570

            Bug ID: 210570
           Summary: ThreadedScrollingTree::scrollingTreeNodeDidScroll()
                    should protect the m_scrollingCoordinator when
                    dispatching its async operation
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Scrolling
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com

Before <https://trac.webkit.org/changeset/258679>, m_scrollingCoordinator was protected. But this was changed in this revision such that "*this" is now protected. This change was done because we needed to call strongThis->removeWheelEventTestCompletionDeferralForReason() also.

In <https://trac.webkit.org/changeset/258753>, the call to strongThis->removeWheelEventTestCompletionDeferralForReason() was removed. But the protection capture code was not changed back.

Protecting "*this" does not guarantee the protection of m_scrollingCoordinator since it is a RefPtr. And this RefPtr can be nullified in ThreadedScrollingTree::invalidate().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200415/cd250cc4/attachment.htm>