[Webkit-unassigned] [Bug 209822] Cannot style ::selection for a flex container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 21:53:25 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=209822

--- Comment #7 from Tyler Wilcock <twilco.o at protonmail.com> ---
I think this should do it.  The TLDR is that RenderText unconditionally checks its direct parent for pseudostyles, but the direct parent of text nodes/runs is often anonymous, and pseudostyles are associated with elements of the DOM (i.e., non-anonymous).  My proposed patch changes RenderText look for pseudostyles by ascending the tree until a non-anonymous renderer is found.  Should be ready for review.

I added two test cases.  I'm running the GTK port of WebKit, so test expectations were added for LayoutTests/platform/gtk.  According to this (https://trac.webkit.org/wiki/CreatingLayoutTests) wiki article, I also need to add test expectations for other platforms.

What is the best way to do this?  I'm not seeing anything on the Builders page that shows newly generated test expectations as the previous article suggests, but perhaps I'm missing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200414/5f8b868c/attachment.htm>


More information about the webkit-unassigned mailing list