[Webkit-unassigned] [Bug 210303] New: Changes to shared testing JS files should not cause test failures due to console message line numbers changing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210303

            Bug ID: 210303
           Summary: Changes to shared testing JS files should not cause
                    test failures due to console message line numbers
                    changing
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

Changing ui-helpers.js can cause other tests that include it, and which trigger console logging to fail:

--- /Volumes/Data/worker/macOS-Mojave-Release-WK2-Tests-EWS/build/layout-test-results/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt
+++ /Volumes/Data/worker/macOS-Mojave-Release-WK2-Tests-EWS/build/layout-test-results/http/tests/adClickAttribution/anchor-tag-attributes-validation-actual.txt
@@ -1,14 +1,14 @@
-CONSOLE MESSAGE: line 197: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
-CONSOLE MESSAGE: line 197: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
-CONSOLE MESSAGE: line 197: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 197: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 197: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
-CONSOLE MESSAGE: line 197: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 197: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 197: addestination could not be converted to a valid HTTP-family URL.
-CONSOLE MESSAGE: line 197: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
-CONSOLE MESSAGE: line 197: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
-CONSOLE MESSAGE: line 197: addestination can not be the same site as the current website.
+CONSOLE MESSAGE: line 207: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
+CONSOLE MESSAGE: line 207: adcampaignid must have a non-negative value less than or equal to 63 for Ad Click Attribution.
+CONSOLE MESSAGE: line 207: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 207: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 207: adcampaignid can not be converted to a non-negative integer which is required for Ad Click Attribution.
+CONSOLE MESSAGE: line 207: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 207: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 207: addestination could not be converted to a valid HTTP-family URL.
+CONSOLE MESSAGE: line 207: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
+CONSOLE MESSAGE: line 207: Both adcampaignid and addestination need to be set for Ad Click Attribution to work.
+CONSOLE MESSAGE: line 207: addestination can not be the same site as the current website.
 Test for validity of ad click attribution attributes on anchor tags.

 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

This is annoying and we need to fix testing infrastructure to avoid it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200409/7c65399d/attachment-0001.htm>