[Webkit-unassigned] [Bug 210041] Should find touch-action elements inside non-composited iframes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 7 14:29:36 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=210041
--- Comment #9 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 395714
--> https://bugs.webkit.org/attachment.cgi?id=395714
First attempt
View in context: https://bugs.webkit.org/attachment.cgi?id=395714&action=review
Thank for the comments!
>> Source/WebCore/page/FrameView.cpp:1262
>> + auto& document = *frame().document();
>
> RefPtr<>? Who knows what cache->postNotification() does.
OK.
>> Source/WebCore/rendering/RenderLayer.cpp:6447
>> +void RenderLayer::eventRegionsChanged()
>
> Why do we need both this and invalidateEventRegion()?
Yeah, I'm going to push all this into invalidateEventRegion() conditioned on a new enumeration argument due to needing setNeedsEventRegionUpdateForNonCompositedDescendant() and setNeedsRepaintAfterCompositingLayerUpdate().
>> Source/WebCore/rendering/RenderLayer.cpp:6452
>> + compositingLayer->renderer().view().setNeedsEventRegionUpdateForNonCompositedDescendant();
>
> This part still bothers me.
Need more info on how to proceed here.
>> Source/WebCore/rendering/RenderLayer.cpp:6453
>> + compositingLayer->renderer().view().setNeedsRepaintAfterCompositingLayerUpdate();
>
> I don't know why we'd need this.
Without this then debug overlays are not painted until something triggers a paint.
>> Source/WebCore/rendering/RenderLayer.cpp:-7006
>> - };
>
> Why remove this logic?
May have jumped the gun.... will revert and patch up to consult renderer().view().needsEventRegionUpdateForNonCompositedDescendant()()
>> Source/WebCore/rendering/RenderLayerBacking.cpp:1621
>> + bool needsEventRegionUpdateForNonCompositedDescendant = renderer().view().needsEventRegionUpdateForNonCompositedDescendant();
>
> The "descendant" here needs to be explicit that it's about Frames.
okiedokkie
>> Source/WebCore/rendering/RenderLayerCompositor.cpp:862
>> + m_renderView.repaintRootContents();
>
> Just to trigger event region generation? That's a huge perf hit.
No, not for event generation. Just to paint the debug paint overlays.
>> Source/WebCore/rendering/RenderWidget.cpp:252
>> + TransformationMatrix transform;
>
> AffineTransform
yep, ahead of you here.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200407/d02687bd/attachment.htm>
More information about the webkit-unassigned
mailing list