[Webkit-unassigned] [Bug 210115] EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210115

--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to Aakash Jain from comment #4)
> (In reply to David Kilzer (:ddkilzer) from comment #0)
> > EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources.
> I like the idea.
> Can we come up with a list of folders for which wk1 tests should be run?
> e.g.: 'Source/WebKitLegacy', 'LayoutTests'

Basically anything in WebKitLegacy or "above", including tests:

Source/bmalloc
Source/WTF
Source/JavaScriptCore
Source/ThirdParty/{ANGLE,libwebrtc,gtest}
Source/WebCore
Source/WebDriver (?)
Source/WebInspectorUI (?)
Source/WebKitLegacy
LayoutTests
Tools

I think it would be easier to say "if the patch only changes files under Source/WebKit, then skip wk1 EWS tests"; rather than "if the patch changes these directories, run wk1 EWS tests".

Maybe it's easier to do the latter, though?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200407/1680acb8/attachment.htm>