[Webkit-unassigned] [Bug 202720] Remove mo at maxsize = "infinite"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202720

--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 395561
  --> https://bugs.webkit.org/attachment.cgi?id=395561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395561&action=review

Maybe you should rename this bug "Remove unnecessary special parsing for mo at maxsize = 'infinite'" or similar. "infinite" is interpreted as "no maximum size" which is exactly the same as the default/invalid behavior, so there is no need for special parsing.

>> Source/WebCore/ChangeLog:10
>> +        the spec at some point in the future (mathml-refresh/mathml#107).
> 
> Using footnotes may be nicer.

Perhaps mention that mstyle at maxsize has never been supported by WebKit so "infinity" has never had any special effect.

>> Source/WebCore/ChangeLog:13
>> +        an invalid or missing value, so there shouldn't be any visible changes.
> 
> What about Firefox?

Everybody should treat them as invalid/unspecified, since "infinite" has always been treated as "no max size".

In the ChangeLog you should explain clearly (with the detailed steps) that we are indeed treated default/invalid behavior value as intMaxForLayoutUnit in the callers of MathMLOperatorElement::maxSize(), as that's not obvious from the patch (I had to re-read the code again).

>> Source/WebCore/mathml/MathMLOperatorElement.cpp:205
>> +    m_maxSize = parseMathMLLength(value);
> 
> Nice to see some of this code go! I think there is no need for the value variable anymore.

Probably even return cachedMathMLLength(MathMLNames::maxizeAttr, m_maxSize) should work now?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200406/16c00384/attachment.htm>