[Webkit-unassigned] [Bug 210056] [WPE][GTK] Several problems with new GTK select elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 11:05:10 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=210056

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
This commit introduced other regressions too. I'll ask about it:

7f12dc2b66bba15b2e1c0ca077fa4ae58962ec0f is the first bad commit
commit 7f12dc2b66bba15b2e1c0ca077fa4ae58962ec0f
Author: Jonas Ådahl <jadahl at gmail.com>
Date:   Thu Apr 2 16:36:44 2020 +0200

    wayland: Postpone window resize requests until configured

    An application may want to set a fallback size of a window while still
    mapping maximized. This is done by calling gtk_window_resize() before
    gtk_window_maximize() and before gtk_window_show(). When the window is
    mapped, it should have a maximized size, and if it eventually is
    unmaximized, it should fall back to the size from the earlier
    gtk_window_resize() call.

    What happens before this commit is that the initial window size ends up
    respecting the first gtk_window_resize() dimensions, and not the window
    dimension configured by the Wayland display server (i.e. maximized
    dimensions).

    Fix this by postponing any configure events until we received our
    configuration from the display server. If we got one with a fixed size
    (e.g. we're maximized, tiled etc), we use that, otherwise we look at the
    one that was previously configured by gtk which corresponds to the
    "preferred" size when not being maximized.

    This fixes Firefox being started in a maximized state when using the
    Wayland backend.

    Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2538

 gdk/wayland/gdkwindow-wayland.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200406/60292391/attachment.htm>


More information about the webkit-unassigned mailing list