[Webkit-unassigned] [Bug 210017] 'currentcolor' doesn't need setHasExplicitlyInheritedProperties marking anymore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210017

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #395579|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 395579
  --> https://bugs.webkit.org/attachment.cgi?id=395579
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395579&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2169
> +            // While most color properties are not inherited the value 'currentcolor' resolves to the value of the inherited 'color' property.

Needs a comma after the word "inherited".

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2200
> +            for (size_t i = 0; i < shorthand.length(); ++i) {
> +                if (!hasValidStyleForProperty(element, shorthand.properties()[i]))
> +                    return false;
> +            }

Seems like StylePropertyShorthand could use a way to use a for loop without writing it out. Since length() returns unsigned it’s not clear it’s helpful to use size_t for the loop, but that question only arises because we can’t use a modern for loop.

Wish the standard library offered a way to return a pointer and length as a for-loop-compatible range. I’m sure it’s coming in C++20.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200406/e8bae066/attachment-0001.htm>