[Webkit-unassigned] [Bug 210041] Should find touch-action elements inside non-composited iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 5 17:15:06 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=210041

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Hack patch:

[[
diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
index 3a038ce8a3a..0a757275505 100644
--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
@@ -738,7 +738,20 @@ bool RenderLayerCompositor::updateCompositingLayers(CompositingUpdateType update
         return false;
     }

-    if (!m_compositing && (m_forceCompositingMode || (isMainFrameCompositor() && page().pageOverlayController().overlayCount())))
+    auto needsCompositingToUpdateEventRegion = [&] {
+        auto& document = m_renderView.document();
+#if PLATFORM(IOS_FAMILY)
+        if (document.mayHaveElementsWithNonAutoTouchAction())
+            return true;
+#endif
+#if ENABLE(EDITABLE_REGION)
+        if (document.mayHaveEditableElements())
+            return true;
+#endif
+        return false;
+    };
+
+    if (!m_compositing && (m_forceCompositingMode || needsCompositingToUpdateEventRegion() || (isMainFrameCompositor() && page().pageOverlayController().overlayCount())))
         enableCompositingMode(true);

     bool isPageScroll = !updateRoot || updateRoot == &rootRenderLayer();
]]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200406/ca97ff4a/attachment.htm>


More information about the webkit-unassigned mailing list