[Webkit-unassigned] [Bug 209980] New: REGRESSION (r8412): Use RetainPtr<> for NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209980

            Bug ID: 209980
           Summary: REGRESSION (r8412): Use RetainPtr<> for
                    NSMutableAttributedString in
                    -[WebAccessibilityObjectWrapper
                    doAXAttributedStringForTextMarkerRange:spellCheck:]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: darin at apple.com, webkit-bug-importer at group.apple.com

Way back in 2005 in commit r8412, David Harrison added this line of code to WebCore/kwq/KWQAccObject.mm that was never changed to use RetainPtr<>:

    NSMutableAttributedString *attrString = [[NSMutableAttributedString alloc] init];

This lack of RetainPtr<> caused a leak when Darin landed a fix for Bug 209129.

I fixed the leak in Bug 209932 by moving an early return, but Darin was curious about why this variable had never been converted:
<https://bugs.webkit.org/show_bug.cgi?id=209932#c3>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200403/a736d6e0/attachment.htm>