[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

--- Comment #49 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Konstantin Tokarev from comment #44)
> Comment on attachment 395262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395262&action=review
> 
> > Source/JavaScriptCore/CMakeLists.txt:1393
> > +list(APPEND JavaScriptCore_LIBRARIES LowLevelInterpreterLib)
> 
> This should be JavaScriptCore_PRIVATE_LIBRARIES

According to the cmake-3.10 docs (https://cmake.org/cmake/help/v3.10/command/add_library.html#object-libraries), you're not supposed to use target_link_libraris with OBJECT libraries (this limitation has since been lifted, see https://gitlab.kitware.com/cmake/cmake/-/issues/14778).

With this change (in the newer patch, https://bugs.webkit.org/attachment.cgi?id=395371), I can no longer reproduce the issue reported in comment 43.

Still need to reproduce the WinCairo issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200403/2ca65404/attachment.htm>