[Webkit-unassigned] [Bug 209963] [Xcode] Replace ASAN_OTHER_CFLAGS and ASAN_OTHER_CPLUSPLUSFLAGS with $(inherited)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209963

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbedard at apple.com,
                   |                            |jlewis3 at apple.com,
                   |                            |ryanhaddad at apple.com,
                   |                            |tsavell at apple.com

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
BTW, TestWebKitAPI on macOS may not have been built with ASan enabled due to this:

OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) --system-header-prefix=WebKit/;
OTHER_CFLAGS[sdk=macosx*] = $(inherited) -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);

So this change might surface some issues in macOS-only TestWebKitAPI tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200403/7c6823c8/attachment.htm>