[Webkit-unassigned] [Bug 209805] [GTK] Bring back support for rendering scrollbars using the system appearance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209805

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #12)
> Comment on attachment 395032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395032&action=review
> 
> I don't have a good answer.
> 
> For GTK 4, where we have no choice, I guess we can blame GTK 4 when users
> complain. GTK 4 will be stable very soon anyway. But as long as we're using
> GTK 3, I think I'd prefer native scrollbars to avoid user complaints, since
> we can't blame GTK 4 for that.

I don't think this is about who to blame, but what behavior we want for WebKitGTK.

> > Tools/MiniBrowser/gtk/main.c:546
> > +    WebKitWebContext *webContext = g_object_new(WEBKIT_TYPE_WEB_CONTEXT, "website-data-manager", manager, "process-swap-on-cross-site-navigation-enabled", TRUE,
> > +        "use-system-appearance-for-scrollbars", FALSE, NULL);
> 
> Since this property is not construct-only, and can be changed after the web
> process has started... why not put it into WebKitSettings instead?

Because WebKitSettings can be set per web view, but RenderScrollbarTheme is a singleton in the web process, so we can't change the setting for a particular page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200402/a64df1b0/attachment.htm>