[Webkit-unassigned] [Bug 209332] [GStreamer] Lazy initialization support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209332

Charlie Turner <cturner at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cturner at igalia.com

--- Comment #1 from Charlie Turner <cturner at igalia.com> ---
It sounds like a good idea to only initialise GStreamer if we're going to play media. TL;DR, it's fine to do this but it might break WebRTC.

Currently, Gst can be initialised by either

 1/ WebProcess initialization - so for every web view, there will be a gst_init (and potentially a registry rebuild...)

 2/ MediaPlayerPrivateGStreamer::isAvailable - this is called when media engines are registered

1/ seems like the wrong thing to do, and 2/ is sensible. 2/ happens when you call an API like webkit_web_view_can_show_mime_type or load a page with media elements. Spinning up for the MIME APIs could be avoided if we maintain a static whitelist like other ports do, but we elect to dynamically answer this question, I guess to support use-cases like codec auto-install (which is busted as well unfortunately).

I have WIP patch that I'll attach, it only spins Gst up if we really need it. After testing I realised that WebRTC tests for the GTK port are busted, as well as basic WebRTC test pages. Because I don't have time to fix WebRTC I will leave it here in case it's useful after WebRTC gets some love in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200402/0f94416a/attachment-0001.htm>